Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(compiler): rename _ParseAST.optionalCharacter TemplateBinding.expression #35886

Closed
wants to merge 1 commit into from
Closed

refactor(compiler): rename _ParseAST.optionalCharacter TemplateBinding.expression #35886

wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Mar 5, 2020

This commit renames

  1. _ParseAST.optionalCharacter -> consumeOptionalCharacter
  2. TemplateBinding.expression -> value

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from ayazhafiz March 5, 2020 23:08
@kyliau kyliau added area: compiler Issues related to `ngc`, Angular's template compiler and removed cla: yes labels Mar 5, 2020
@ngbot ngbot bot added this to the needsTriage milestone Mar 5, 2020
@kyliau kyliau added target: patch This PR is targeted for the next patch release and removed cla: yes labels Mar 5, 2020
AndrewKushnir
AndrewKushnir approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kyliau kyliau force-pushed the rename-consume-optional-and-expression branch from 03128f9 to 9dc3935 Compare March 5, 2020 23:20
@ayazhafiz ayazhafiz added the action: merge The PR is ready for merge by the caretaker label Mar 5, 2020
@kyliau
refactor(compiler): rename _ParseAST.optionalCharacter TemplateBindin…
ab928e4 
…g.expression

This commit renames
1. _ParseAST.optionalCharacter -> consumeOptionalCharacter
2. TemplateBinding.expression -> value
@kyliau kyliau force-pushed the rename-consume-optional-and-expression branch from 9dc3935 to ab928e4 Compare March 5, 2020 23:41
@matsko matsko closed this in bef14cf Mar 6, 2020
matsko pushed a commit that referenced this pull request Mar 6, 2020
@kyliau @matsko
refactor(compiler): rename _ParseAST.optionalCharacter TemplateBindin…
9a9cc01 
…g.expression (#35886)

This commit renames
1. _ParseAST.optionalCharacter -> consumeOptionalCharacter
2. TemplateBinding.expression -> value

PR Close #35886
@kyliau kyliau mentioned this pull request Mar 10, 2020
Closed
14 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 6, 2020
@kyliau kyliau deleted the rename-consume-optional-and-expression branch September 30, 2020 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ayazhafiz ayazhafiz ayazhafiz approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kyliau @ayazhafiz @AndrewKushnir @googlebot